Run CI on GitHub actions #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise we won't be able to run against ruby head which is now identifying itself as 3.x
Decided to have this as a separate flow to separate the concerns. The downside is that we scatter the Ruby version in two files, but I believe it's the lesser of evils.
roback
approved these changes
Dec 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to loosen the requirement on Ruby so that we cold run on Ruby head. I split the Travis CI things into two separate workflows as it made sense. One workflow is concerned about running the specs and one is concerned about trying the install phase. The downside here is that we have two workflows and Ruby versions scattered in two files, but I think it's still the lesser of evils.